Fix #9958: Avoid eta contractions when printing #9979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't eta contract if the result type of a lambda is an applied type that's treated specially.
odersky
changed the title
|
Does this also fixes #9971? |
The unapply method of EtaExpansion was missing several necessary conditions, which are now added: - parameters and arguments must have same length - bounds must conform
|
#9971 was a different, and deeper problem. It's now also fixed. |
|
Fixes #9971 |
nicolasstucki
force-pushed
the
fix-#9958
branch
from
37a7924 to
5e56416
Compare
nicolasstucki
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
LGTM.
It looks like #9965 is starting to cause issues in many places.
| onlyEmptyBounds | ||
| // Note: this pre-test helps efficiency. It is also necessary since in some cases | ||
| // tparams is empty. This can happen when we change the owners of inlined local | ||
| // classes in mapSymbols. See pos/reference/delegates.scala for an example. |
There was a problem hiding this comment.
It is the manifestation of #9965 which I also encountered in #9954.
It happens when inlining
https://github.com/lampepfl/dotty/blob/a128dab3a435a9eb3aa7a8cba359a9989a73d9c2/tests/pos/reference/delegates.scala#L114-L115
There was a problem hiding this comment.
@odersky does this match what you saw while debugging or are there other problematic cases?
There was a problem hiding this comment.
That's what I saw, yes.
Co-authored-by: Nicolas Stucki <nicolas.stucki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't eta contract if the result type of a lambda is an applied
type that's treated specially.